cleanup environment #129
Merged
cleanup environment #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Dec 20, 2018
| # super().__init__(name='') | ||
|
|
||
|
|
||
| class AbstractQuestSelectorParameterized(param.parameterized.ParameterizedMetaclass, ABCMeta): pass |
There was a problem hiding this comment.
E701 multiple statements on one line (colon)
| @@ -3,5 +3,5 @@ | |||
| from .config import get_settings, save_settings, update_settings, update_settings_from_file | |||
| from .log import logger, log_to_console, log_to_file | |||
| from . import param_util as param | |||
| from .param_util import format_json_options, ServiceSelector, PublisherSelector | |||
| from .param_util import format_json_options, ProviderSelector, ServiceSelector, PublisherSelector, ParameterSelector | |||
There was a problem hiding this comment.
F401 '.param_util.ServiceSelector' imported but unused
F401 '.param_util.format_json_options' imported but unused
F401 '.param_util.ProviderSelector' imported but unused
F401 '.param_util.ParameterSelector' imported but unused
F401 '.param_util.PublisherSelector' imported but unused
1 similar comment
Pull Request Test Coverage Report for Build 603
💛 - Coveralls |
AaronV77
approved these changes
Dec 21, 2018
sdc50
added a commit
to sdc50/quest
that referenced
this pull request
Apr 2, 2019
fixes 126 fixes 130 fixes 131
sdc50
added a commit
to sdc50/quest
that referenced
this pull request
Apr 2, 2019
remove python 3.5 from testing (environment can't resolve) fixes 126 fixes 130 fixes 131
sdc50
added a commit
that referenced
this pull request
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup environment and update setup.cfg metadata
fix bug caused by new package distribution name