Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 2.1 by adding Widget.render's argument renderer #75

Merged
merged 3 commits into from
Aug 14, 2018

Conversation

tuky
Copy link
Contributor

@tuky tuky commented Aug 2, 2018

To support Django < 1.11, the argument renderer is not handed over to the super class, if it is None.

@erdem
Copy link
Owner

erdem commented Aug 13, 2018

@tuky Thank you for your contribution and sorry for delayed reply, I was on holiday.

Did you test the widget with these changes on your project? Are all features worked?

I will re-check these changes in my first free time.

@tuky
Copy link
Contributor Author

tuky commented Aug 13, 2018

Welcome back. Yes, it's in use, but we are only using the GooglePointFieldWidget. My solution works, because the new base classes have renderer=None as an optional keyword argument.

Copy link

@joshsweaney joshsweaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this on my projects and it is working fine.

@erdem erdem merged commit 6712958 into erdem:master Aug 14, 2018
@erdem
Copy link
Owner

erdem commented Aug 14, 2018

@tuky @joshsweaney Thank you for the update guys! It merged.

@jckw
Copy link

jckw commented Sep 3, 2018

Any chance you could update the PyPI package too? Looks like it hasn't had this update yet (last updated 5th June 2017).

@erdem
Copy link
Owner

erdem commented Sep 4, 2018

@jckw I will push the new changes to PyPI in this week after solved this #77 (comment).

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants