Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce synchronous sign+verify #47

Closed
wants to merge 1 commit into from
Closed

introduce synchronous sign+verify #47

wants to merge 1 commit into from

Conversation

JesusMcCloud
Copy link
Contributor

exports synchronous functions verifySync and createSync in addition to the promise-based ones

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.043% when pulling e75fea3 on JesusMcCloud:sync into 92a2b9a on erdtman:master.

This was referenced Jun 9, 2021
Merged
Closed
@oyooyo
Copy link

oyooyo commented Jun 11, 2021

Since I was really missing synchronous versions of cose.sign.create() and cose.sign.verify(), I just did the exact same thing, not being aware that there already is a PR for this.

Please merge, would be really nice to have synchronous alternatives to the API functions when possible.

@oyooyo oyooyo mentioned this pull request Jun 11, 2021
Open
@erdtman
Copy link
Owner

erdtman commented Sep 27, 2021

This was merged with the RSA thing, right?

@oyooyo oyooyo mentioned this pull request Aug 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusMcCloud @coveralls @oyooyo @erdtman