[WIP] Comment submission page styles #362
Conversation
| .success-alert { | ||
| background-color: @green_light; | ||
| display: -webkit-flex; | ||
| display: flex; |
There was a problem hiding this comment.
Looks like IE has significant issues with display: flex. Does it give us much?
There was a problem hiding this comment.
I did a check in Virtualbox with IE11 and it loads okay. According to ATF analytics only 24% are on IE, and of that 87% are on IE11.
There was a problem hiding this comment.
Over 3% of the total users are running IE below 11, and we don't know how indicative ATF is of our general users. I'm wondering if flex is worth it here; it seems like we can accomplish the same end goal without it pretty easily?
|
Styled comment success page: |
|
Styled comment submission fail page: |
xtine
changed the title
|
Tasks remaining for another issue/PR:
|
|
|
||
| <p> | ||
| <a href=""><span class="fa fa-file-pdf-o"></span> Download draft comment (PDF)</a> | ||
| </p> |
There was a problem hiding this comment.
Let's comment this out until the JS functionality is available
|
Without the comment success PDF and tracking number, this is a functionality regression. We shouldn't merge these styles until functionality is restored. Does that make sense? |
|
I just commented out any mentions of PDF downloads. Looks like this: Can we merge styles like this and then add the PDF mentions once JS is in? |
|
I don't think this can be merged with the JS regression; it'd block 18F/epa-notice#299 and 18F/epa-notice#306 . If you don't have time to try to fix, I can take a look later today |
This uses underscore templates so that the templates associated with the PDF download and tracking number are part of the markup (rather than only being present in the JS)
|
xtine#4 brings back the JS functionality |
Bring back pdf link and tracking number
|
@cmc333333: feel free to merge this, I'll push another PR for updates. |
|
👍 |
Set Comment submission styles for 18F/epa-notice#238