Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add template annotations #128

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • adds @template annotations to assist with static code analysis

@localheinz localheinz self-assigned this Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #128 into master will increase coverage by 1.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     94.44%   95.45%   +1.01%     
  Complexity       71       71              
============================================
  Files            12       12              
  Lines           198      198              
============================================
+ Hits            187      189       +2     
+ Misses           11        9       -2     
Impacted Files Coverage Δ Complexity Δ
src/FieldDefinition.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/FixtureFactory.php 93.39% <100.00%> (+1.88%) 39.00 <9.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ac7b8...3dbfd6c. Read the comment docs.

@localheinz localheinz force-pushed the feature/template branch 2 times, most recently from 34f23c4 to aee9a9b Compare March 30, 2020 18:55
@localheinz localheinz marked this pull request as ready for review March 30, 2020 18:55
@localheinz localheinz merged commit 117d686 into master Mar 30, 2020
@localheinz localheinz deleted the feature/template branch March 30, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants