Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move classes imported from breerly/factory-girl #17

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 9, 2020

This PR

  • moves classes imported from breerly/factory-girl

Follows #1.

@localheinz localheinz added the bug label Mar 9, 2020
@localheinz localheinz self-assigned this Mar 9, 2020
@localheinz localheinz force-pushed the fix/move branch 3 times, most recently from 599c939 to 019b714 Compare March 9, 2020 20:54
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #17 into master will decrease coverage by 12.37%.
The diff coverage is 52.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #17       +/-   ##
=============================================
- Coverage     74.22%   61.85%   -12.38%     
  Complexity       80       80               
=============================================
  Files             8        8               
  Lines           194      194               
=============================================
- Hits            144      120       -24     
- Misses           50       74       +24
Impacted Files Coverage Δ Complexity Δ
src/Definition/Definitions.php 92.85% <ø> (+92.85%) 13 <0> (ø) ⬇️
src/EntityDef.php 0% <0%> (ø) 18 <9> (?)
src/FieldDef.php 0% <0%> (ø) 6 <0> (?)
src/EntityDefinitionUnavailable.php 100% <100%> (ø) 2 <2> (?)
src/FixtureFactory.php 93.82% <93.75%> (ø) 36 <15> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1bfb5...82fa52f. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review March 10, 2020 00:39
@localheinz localheinz force-pushed the fix/move branch 6 times, most recently from 6afa068 to c25e111 Compare March 10, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant