Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove possibility to specify entity namespace #3

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

localheinz
Copy link
Member

This PR

  • removes the possibility to set an entity namespace on the FixtureFactory

💁‍♂ This should not be necessary since PHP 5.5 and the introduction of the class keyword, see https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class.

@localheinz localheinz added the bug label Mar 8, 2020
@localheinz localheinz self-assigned this Mar 8, 2020
@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #3 into master will decrease coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master       #3     +/-   ##
===========================================
- Coverage     59.82%   59.23%   -0.6%     
+ Complexity      138      134      -4     
===========================================
  Files            11       11             
  Lines           351      341     -10     
===========================================
- Hits            210      202      -8     
+ Misses          141      139      -2
Impacted Files Coverage Δ Complexity Δ
src/Doctrine/FixtureFactory.php 97.53% <100%> (+1.92%) 36 <0> (-4) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da4e4e...828daf7. Read the comment docs.

@localheinz localheinz merged commit 8ec0b5b into master Mar 8, 2020
@localheinz localheinz deleted the fix/namespace branch March 8, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant