Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move resolution of Count to FixtureFactory #351

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • moves the responsibility for resolving the value of Count from Count to FixtureFactory

@localheinz localheinz self-assigned this Jul 25, 2020
@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #351 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #351   +/-   ##
=========================================
  Coverage     98.93%   98.93%           
  Complexity      100      100           
=========================================
  Files            22       22           
  Lines           281      281           
=========================================
  Hits            278      278           
  Misses            3        3           
Impacted Files Coverage Δ Complexity Δ
src/Count.php 100.00% <100.00%> (ø) 8.00 <2.00> (ø)
src/FixtureFactory.php 97.85% <100.00%> (+0.03%) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f40d10...4df0420. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 25, 2020 17:45
@ergebnis-bot ergebnis-bot self-assigned this Jul 25, 2020
@ergebnis-bot ergebnis-bot merged commit 029cc92 into main Jul 25, 2020
@ergebnis-bot ergebnis-bot deleted the fix/resolution branch July 25, 2020 17:45
@localheinz localheinz mentioned this pull request Jul 25, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants