Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Require and use phpstan/phpstan-doctrine #41

Merged
merged 3 commits into from
Mar 14, 2020
Merged

Enhancement: Require and use phpstan/phpstan-doctrine #41

merged 3 commits into from
Mar 14, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 14, 2020 •
edited
Loading

This PR

  • requires phpstan/phpstan-doctrine
  • configures phpstan/phpstan-doctrine
  • fixes issues reported via static code analysis

@localheinz localheinz self-assigned this Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 14, 2020 •
edited
Loading

Codecov Report

Merging #41 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage     61.22%   61.22%           
  Complexity       81       81           
=========================================
  Files             8        8           
  Lines           196      196           
=========================================
  Hits            120      120           
  Misses           76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814d9bf...e36ba5a. Read the comment docs.

@localheinz localheinz force-pushed the feature/phpstan-doctrine branch 2 times, most recently from bb929b4 to ce10c51 Compare March 14, 2020 19:04
@localheinz localheinz marked this pull request as ready for review March 14, 2020 21:04
@localheinz localheinz merged commit 19c3864 into master Mar 14, 2020
@localheinz localheinz deleted the feature/phpstan-doctrine branch March 14, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz