Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add inline DocBlocks to assist with type resolution #45

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Fix: Add inline DocBlocks to assist with type resolution #45

merged 2 commits into from
Mar 15, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 15, 2020 •
edited
Loading

This PR

  • adds inline DocBlocks to assist with type resolution
  • fixes issues reported via static analysis

Follows #1.

@localheinz localheinz added the bug label Mar 15, 2020
@localheinz localheinz self-assigned this Mar 15, 2020
@codecov
Copy link

codecov bot commented Mar 15, 2020 •
edited
Loading

Codecov Report

Merging #45 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage     61.22%   61.22%           
  Complexity       81       81           
=========================================
  Files             8        8           
  Lines           196      196           
=========================================
  Hits            120      120           
  Misses           76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d098fa...74e28b8. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review March 15, 2020 11:30
@localheinz localheinz merged commit d432211 into master Mar 15, 2020
@localheinz localheinz deleted the fix/type branch March 15, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@localheinz