Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract NewLine value object #76

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Conversation

localheinz
Copy link
Member

This PR

  • extracts a new line value object

@localheinz localheinz self-assigned this Aug 13, 2018
@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #76   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      112    114    +2     
=======================================
  Files            14     15    +1     
  Lines           329    331    +2     
=======================================
+ Hits            329    331    +2
Impacted Files Coverage Δ Complexity Δ
src/Format/NewLine.php 100% <100%> (ø) 4 <4> (?)
src/Format/Format.php 100% <100%> (ø) 11 <4> (-2) ⬇️
src/Format/Formatter.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Format/Sniffer.php 100% <100%> (ø) 12 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799f3f1...473ecf4. Read the comment docs.

@localheinz localheinz merged commit 6b3f910 into master Aug 18, 2018
@localheinz localheinz deleted the feature/new-line branch August 18, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant