Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement AbstractOrFinalRule #1

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

localheinz
Copy link
Member

This PR

  • implements an AbstractOrFinalRule, which reports an error when a non-anonymous class is neither abstract nor final

Related to https://twitter.com/localheinz/status/1062284076680470529.

/cc @matthiasnoback @ondrejmirtes

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@16a0a11). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%           
  Complexity        ?      5           
=======================================
  Files             ?      1           
  Lines             ?     10           
  Branches          ?      0           
=======================================
  Hits              ?     10           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ Complexity Δ
src/Classes/AbstractOrFinalRule.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a0a11...fb80aec. Read the comment docs.

@localheinz localheinz force-pushed the feature/abstract-or-final branch 6 times, most recently from 15ebed1 to 87cd91a Compare November 13, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant