Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reorganize fixtures #24

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Fix: Reorganize fixtures #24

merged 3 commits into from
Nov 21, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 21, 2018

This PR

  • reorganizes fixtures
  • correctly uses AbstractClass as fixture for FinalRule failure case

πŸ’β€β™‚οΈ This way it is easier to spot what should be success or failure.

@localheinz localheinz added the bug label Nov 21, 2018
@localheinz localheinz self-assigned this Nov 21, 2018
@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #24   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       21     21           
=======================================
  Files             4      4           
  Lines            50     50           
=======================================
  Hits             50     50

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 67e6f6a...b8ae78a. Read the comment docs.

@localheinz localheinz merged commit fcbd2ca into master Nov 21, 2018
@localheinz localheinz deleted the fix/reorganize branch November 21, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant