Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Closures\NoNullableReturnTypeDeclarationRule #29

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

localheinz
Copy link
Member

This PR

  • implements a Closures\NoNullableReturnTypeDeclarationRule, which reports an error when a closure uses a nullable return type declaration

@localheinz localheinz self-assigned this Nov 23, 2018
@localheinz localheinz force-pushed the feature/no-nullable-return-type-declaration-rule branch 2 times, most recently from a9c3c8f to 4ff165c Compare November 23, 2018 23:11
@localheinz localheinz force-pushed the feature/no-nullable-return-type-declaration-rule branch from 4ff165c to be93fa1 Compare November 23, 2018 23:11
@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #29   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       21     24    +3     
=======================================
  Files             4      5    +1     
  Lines            50     56    +6     
=======================================
+ Hits             50     56    +6
Impacted Files Coverage Δ Complexity Δ
...c/Closures/NoNullableReturnTypeDeclarationRule.php 100% <100%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00fcd4...be93fa1. Read the comment docs.

@localheinz localheinz merged commit 0fd9787 into master Nov 23, 2018
@localheinz localheinz deleted the feature/no-nullable-return-type-declaration-rule branch November 23, 2018 23:25
@localheinz localheinz mentioned this pull request Nov 23, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant