Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Methods\NoParameterWithNullableTypeDeclarationRule #35

Merged

Conversation

localheinz
Copy link
Member

This PR

  • implements Methods\NoParameterWithNullableTypeDeclarationRule, which reports an error when a method declared on an anonymous class, a class, or an interface has a parameter with a nullable type declaration

@localheinz localheinz self-assigned this Nov 24, 2018
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #35   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       48     53    +5     
=======================================
  Files            10     11    +1     
  Lines           154    182   +28     
=======================================
+ Hits            154    182   +28
Impacted Files Coverage Δ Complexity Δ
...ods/NoParameterWithNullableTypeDeclarationRule.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c0944...0ee4e8c. Read the comment docs.

@localheinz localheinz force-pushed the feature/methods-no-parameter-with-nullable-type-declaration branch from 7ba5b97 to 0ee4e8c Compare November 25, 2018 01:51
@localheinz localheinz merged commit 14b00ba into master Nov 25, 2018
@localheinz localheinz deleted the feature/methods-no-parameter-with-nullable-type-declaration branch November 25, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant