Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker build is broken #2071

Closed
slingamn opened this issue Jun 2, 2023 · 2 comments · Fixed by #2072
Closed

docker build is broken #2071

slingamn opened this issue Jun 2, 2023 · 2 comments · Fixed by #2072
Labels
bug
Milestone
v2.12.0

Comments

@slingamn
Copy link
Member

slingamn commented Jun 2, 2023

https://github.com/ergochat/ergo/actions/runs/5154767068/jobs/9283612607

I think this is because Alpine 3.13 is EOL? @csmith would you have time to take a look at this? If not I can probably get to it soon.
@slingamn slingamn added the bug label Jun 2, 2023
@slingamn slingamn added this to the v2.12.0 milestone Jun 2, 2023
@csmith
Copy link
Contributor

csmith commented Jun 2, 2023

Hmm, it's failing on the build step which is actually Alpine 3.18 (because that's what golang:1.20-alpine uses).

It looks like the problem is that golang:1.20-alpine contains busybox 1.36.0-r9:

$ syft -q golang:1.20-alpine | grep busybox
busybox                 1.36.0       binary     
busybox                 1.36.0-r9    apk        
busybox-binsh           1.36.0-r9    apk

But according to the repository 1.36.1-r0 is the current version as of ~24 hours ago. The packages we're trying to install transitively depend on busybox, and apk is unhappy because of the conflict in versions.

I guess if the golang:1.20-alpine isn't rebuilt when packages are changed, then the ergo Dockerfile needs to do a apk upgrade before trying to install anything.

csmith added a commit to csmith/oragono that referenced this issue Jun 2, 2023
@csmith
Dockerfile: apk upgrade before add
e401b86 
The base golang image ships with some packages pre-installed,
but they're not necessarily the latest. If we try to add a
package that (transitively) depends on one of the existing ones,
it'll fail if it's expecting a newer version.

To address this, simply `apk upgrade` before trying to `apk add`.

Closes ergochat#2071
csmith added a commit to csmith/oragono that referenced this issue Jun 2, 2023
@csmith
Dockerfile: apk upgrade before add
783b579 
The base golang image ships with some packages pre-installed,
but they're not necessarily the latest. If we try to add a
package that (transitively) depends on one of the existing ones,
it'll fail if it's expecting a newer version.

To address this, simply `apk upgrade` before trying to `apk add`.

Closes ergochat#2071
@csmith csmith mentioned this issue Jun 2, 2023
Merged
@slingamn
Copy link
Member Author

slingamn commented Jun 2, 2023

Thanks so much! I remember now that we cannot safely upgrade beyond 3.13 for the actual production image, because of the faccessat2(2) issue: #1726

@dallemon dallemon mentioned this issue Nov 28, 2023
Closed
@slingamn slingamn mentioned this issue Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

Dockerfile: apk upgrade before add csmith/oragono
2 participants
@csmith @slingamn