Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_bytes to SecretKey #147

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Add to_bytes to SecretKey #147

merged 2 commits into from
Nov 18, 2020

Conversation

SebastienGllmt
Copy link
Collaborator

I needed this for debugging. Figured it might be useful for somebody else in the future.

@SebastienGllmt SebastienGllmt self-assigned this Nov 17, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 962

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • 75 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 87.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/wallet/secret_key.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
ergo-lib/src/ast.rs 5 37.5%
ergo-lib/src/ergo_tree.rs 13 90.48%
ergo-lib/src/chain/address.rs 23 76.72%
ergo-lib/src/ast/constant.rs 34 76.1%
Totals Coverage Status
Change from base Build 929: 0.1%
Covered Lines: 2596
Relevant Lines: 2982

💛 - Coveralls

Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good! Please fix formatting (red CI).

@greenhat greenhat merged commit 5e8baa6 into develop Nov 18, 2020
@greenhat greenhat deleted the secret-key-to-bytes branch November 18, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants