-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tap To Select Not Working (on iPhone) #13
Comments
I found that if you:
|
It works on Android Chrome. But why do you have the button say press n hold? Tapping the button selects all text and places on clipboard(in chrome). Earlier labels were more meaningful. Perhaps for safari it should not say 'Copied' |
Ah, I have it say that because on iPhone Safari and iPhone chrome the button won't actually do anything when you tap. I found that if you press and hold (above comment), it'll allow you to select all of it. Do you have access to an iOS device to test on? |
Nope. On Android if you press and hold the button, it will select button text. Does not tapping on the select button select the emoji code? It should. Selection is supported in safari. Ideally it should say |
No when you tap the button, nothing happens. That's why I changed the button text. The press and hold has the same effect on mobile safari, but once you tap to deselect the button text, it somehow magically selects the emoji text. So it's a "hack" until we can resolve why a single tap on the button isn't selecting the text. I'll do a screen record so you can see. |
Check it out https://www.dropbox.com/s/2bdvnpynd56nzrm/issue2.mov?dl=0 You can see, I tap the button (it changes text every tap) multiple times before I press and hold it. Once I press and hold, it behaves just like you android, but then one more tap, and somehow all the text is selected. Is there anything I can do to help troubleshoot? |
Tap to select needs to be fixed. |
fixes #13 and weird safari and messaging bug
I just packaged the latest: http://lobdell.me/emoji-gram/ iPhone still doesn't want to select the text 🤔 However it looks like the Safari / iMessage react issue is totally resolved!! That's awsome!! I ran: "npm run build" then copied the files to my server after linking the css file. Is it possible something is getting messed up in the packaging process? |
OK, I found mobile safari don't support the API used for text selection. I tried using a textarea (so that we can select text) but then there is this weird |
Would this be a simple way to fix this? http://stackoverflow.com/questions/1899421/selecting-text-in-mobile-safari-on-iphone Not just the first answer, but a couple people down the thread seem to have fixes working for them. Just poking around. |
Need an iphone to test :( |
Dang. I tried to plugin my iPhone and use the developer console for a debug, but no errors / warnings appeared. So, no help 👎 Anyhow, I took to the internet again: http://stackoverflow.com/questions/38233871/auto-select-text-range-in-mobile-safari-ios-9-reactjs -- maybe someone can help us! |
Hmm, only workaround is using a textarea but I'm not sure where that |
It looks like the latest bugfix only brings up the keyboard when you press the button. It's acting like the text area is being focused instead of selecting everything. www.lobdell.me/emoji-gram -- is the latest master + bugfix. |
Resolved with: |
http://www.lobdell.me/emoji-gram
-- Test from mobile safari / mobile chrome. The button doesn't actually make a selection of the text.
The text was updated successfully, but these errors were encountered: