Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - remove use of node Buffer #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yogeshgadge
Copy link

just removed Buffer from type definitions

Copy link

rollingversions bot commented May 1, 2024

Change Log for @ericblade/quagga2 (1.8.4 → 1.9.0)

Refactors

  • Browser targeted Typescript apps can now use quagga2 without adding node types

Edit changelog

@ericblade
Copy link
Owner

i'd like to have a look at the node code that takes the buffer input, and make sure that it doesn't do anything weird, but good to know that this should fix the consumer side of it. I'm actually guessing that it probably works fine, just that this was all written long before Buffer was actually an extension of Uint8Array in node

@ericblade
Copy link
Owner

all tests successful, so it's pretty likely that there's no issue here, but i do want to take a look at the code in question before i merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants