Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add module to available options #20

Merged
merged 1 commit into from Apr 24, 2013

Conversation

Projects
None yet
2 participants
Contributor

sidwood commented Apr 24, 2013

Hi there,

This commit allows for grunt targets that do not match the angular module name. It's fully backwards compatible, includes tests, and a README update.

Let me know if you have any concerns or change requests.

Cheers,

Sid

@sidwood sidwood Add module to available options
Allow for grunt targets that do not match the angular module name.
5e89d26

@ericclemmons ericclemmons commented on the diff Apr 24, 2013

README.md
base: 'src/views', // $templateCache ID will be relative to this folder
- prepend: '/static/assets/' // (Optional) Prepend path to $templateCache ID
+ prepend: '/static/assets/', // (Optional) Prepend path to $templateCache ID
+ module: 'App' // (Optional) The module the templates will be added to, defaults to target if not present ('build' in this case)
@ericclemmons

ericclemmons Apr 24, 2013

Owner

The whitespace nazi in me wants to align the // part, but I can't argue with progress!

@sidwood

sidwood Apr 24, 2013

Contributor

I know what you mean. I'm a right margin nut so the whole line was making me hyperventilate.

@ericclemmons

ericclemmons Apr 24, 2013

Owner

Sounds like we should work together :)

I ended up splitting it up into 2 lines for v0.3.2, so we both win!

@ericclemmons ericclemmons added a commit that referenced this pull request Apr 24, 2013

@ericclemmons ericclemmons Merge pull request #20 from sidwood/module-option
Add module to available options
53d618b

@ericclemmons ericclemmons merged commit 53d618b into ericclemmons:master Apr 24, 2013

1 check passed

default The Travis build passed
Details
Owner

ericclemmons commented Apr 24, 2013

71685ba

v0.3.2 should be available via NPM.

Thanks for the awesome PR!

Contributor

sidwood commented Apr 25, 2013

And thank you for the speedy merge!

@sidwood sidwood deleted the sidwood:module-option branch Jun 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment