Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trash from 4.1.1 to 5.0.0 #250

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2024

Bumps trash from 4.1.1 to 5.0.0.

Release notes

Sourced from trash's releases.

v5.0.0

To support non-UTF8 encoding in paths, the name field changed from String to OsString in the TrashItem struct. As it's a return value, one won't see code break unless name is actually used.

Bug Fixes

  • Support non-Unicode paths There are several spots where paths are assumed to be Unicode. However, some (all?) operating systems support non-Unicode paths which causes trash-rs to panic if encountered. I switched some of those code to use OsStrings instead of Strings. Unfortunately, I had to add a new dependency, urlencoding, in order to properly handle decoding non-UTF8 byte slices.

    As of this commit, the test suite passes and code should be ready, but I will try to remove the url crate and use urlencoding in its place in the next commit.

Other

  • Use objc2-foundation

Bug Fixes (BREAKING)

  • Support non-UTF8 paths. Note that this changes the type of returned paths to OsString from String, hence the breaking change.

Commit Statistics

  • 10 commits contributed to the release over the course of 34 calendar days.
  • 47 days passed between releases.
  • 3 commits were understood as conventional.
  • 0 issues like '(#ID)' were seen in commit messages

Commit Details

  • Uncategorized
    • Prepare changelog prior to release (02d1a8d)
    • Support non-UTF8 paths. (0971b8f)
    • Update Windows code to account for API change (e4b7119)
    • Simplify Linux/BSD only tests for non-UTF8 paths (559b57b)
    • Impl test for listing invalid UTF8 trash items (209db9d)
    • Cleanup non-Unicode support for readability (2f31116)
    • Remove url and replace with urlencoding (67fb256)

... (truncated)

Changelog

Sourced from trash's changelog.

5.0.0 (2024-06-18)

To support non-UTF8 encoding in paths, the name field changed from String to OsString in the TrashItem struct. As it's a return value, one won't see code break unless name is actually used.

Bug Fixes

  • Support non-Unicode paths There are several spots where paths are assumed to be Unicode. However, some (all?) operating systems support non-Unicode paths which causes trash-rs to panic if encountered. I switched some of those code to use OsStrings instead of Strings. Unfortunately, I had to add a new dependency, urlencoding, in order to properly handle decoding non-UTF8 byte slices.

    As of this commit, the test suite passes and code should be ready, but I will try to remove the url crate and use urlencoding in its place in the next commit.

Other

  • Use objc2-foundation

Bug Fixes (BREAKING)

  • Support non-UTF8 paths. Note that this changes the type of returned paths to OsString from String, hence the breaking change.

Commit Statistics

  • 10 commits contributed to the release over the course of 34 calendar days.
  • 47 days passed between releases.
  • 3 commits were understood as conventional.
  • 0 issues like '(#ID)' were seen in commit messages

Commit Details

  • Uncategorized
    • Prepare changelog prior to release (02d1a8d)
    • Support non-UTF8 paths. (0971b8f)

... (truncated)

Commits
  • a754f4a Release trash v5.0.0
  • 02d1a8d prepare changelog prior to release
  • 0971b8f fix!: Support non-UTF8 paths.
  • e4b7119 Update Windows code to account for API change
  • 559b57b Simplify Linux/BSD only tests for non-UTF8 paths
  • 209db9d Impl test for listing invalid UTF8 trash items
  • 2f31116 Cleanup non-Unicode support for readability
  • 67fb256 Remove url and replace with urlencoding
  • 15a15f8 fix: Support non-Unicode paths
  • 46585ce Merge pull request #107 from madsmtm/objc2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [trash](https://github.com/ArturKovacs/trash) from 4.1.1 to 5.0.0.
- [Release notes](https://github.com/ArturKovacs/trash/releases)
- [Changelog](https://github.com/Byron/trash-rs/blob/master/CHANGELOG.md)
- [Commits](Byron/trash-rs@v4.1.1...v5.0.0)

---
updated-dependencies:
- dependency-name: trash
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Changes to the project's dependencies label Jun 19, 2024
@ericcornelissen ericcornelissen merged commit 4268905 into main Jun 19, 2024
22 checks passed
@ericcornelissen ericcornelissen deleted the dependabot/cargo/trash-5.0.0 branch June 19, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the project's dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant