Make ElGrapho UMD friendly for node+webpack environments #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: (37 commits) fix comment no double quotes removed webcola and added d3-force first cached result fix changelog models to layouts v2 another readme change more changes readme change updates tweaks new FDG, and collapsing model stuff finished updating all of the examples with new API more grinding through new API work first pass big API change half done stuff more stuff more stuff ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a couple of fixes to make ElGrapho UMD friendly, allowing it work in the browser (via window), and in node.js / webpack / babel (via UMD).
windowobject (let webpack take care of that)The original webpack 3 signature for UMD was
typeof self !== \'undefined\' ? self : this, but we can use the window object safely with a typeof guard in webpack 4.