Fixing reverse_iterator's value_type. #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverse_iterator
doesn't properly forwardvalue_type
, so in cases where the underlying range'svalue_type
is not simplyuncvref_t<reference>
,views::reverse
will end up destroying that information - which is especially problematic if you'rereverse
ing azip
and then do some work that relies on thevalue_type
not having reference semantics.