Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reverse_iterator's value_type. #1670

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

brevzin
Copy link
Collaborator

@brevzin brevzin commented Oct 22, 2021

reverse_iterator doesn't properly forward value_type, so in cases where the underlying range's value_type is not simply uncvref_t<reference>, views::reverse will end up destroying that information - which is especially problematic if you're reverseing a zip and then do some work that relies on the value_type not having reference semantics.

@brevzin brevzin merged commit 5626ab6 into ericniebler:master Jun 2, 2022
@brevzin brevzin deleted the reverse-value-type branch June 2, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant