Auto context with async insertion #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now call queue.add_async() withing the context, and get the results when the context is exited.
|
Builds off of the AutoContext main PR: Workiva#105 |
Conflicts: furious/context/auto_context.py
Also make sure the contents of the return list are correctly formatted as FutureInfo namedtuples.
| self.async_insert = async_insert | ||
|
|
||
| self._insert_tasks_async = options.pop( | ||
| 'insert_tasks_async', insert_tasks_async) |
There was a problem hiding this comment.
Not sure if it's so good to allow both options: 'insert_tasks' and 'insert_tasks_async', but their returns and usage are quite a bit different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making queue add an async call.
For now call queue.add_async() withing the context, and get the
results when the context is exited.
Debating/Question: Will it work well to delay getting the future result until some time after we've exited the context?