Dog-fooding: Use grate to version grate tables #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbra
force-pushed
the
chore/meta-grate2
branch
5 times, most recently
from
9241593
to
35a5eed
Compare
erikbra
changed the title
Use grate itself to version the grate tables, instead of doing this explicitly in code. This is good for two reasons: 1) We use the best tool out there to version the database ;) 2) It makes (overdue) changes to some of the grate tables (using outdated types, etc) easier I introduced a set of "meta" grate tables to handle the versioning of the Grate tables themselves. So, in addition to (default names): * ScriptsRun * ScriptsRunErrors * Version we add these tables, to version the tables above: * GrateScriptsRun * GrateScriptsRunErrors * GrateVersion for versioning these tables themselves, we put the versioning _in_ the same tables (using delayed writing to the tables for bootstrapping) * Wrote tests for existing functionality to make sure we don't break anything * Made sure internal tables are created * Fixed case-sensitivity in tests * Smink -> 0.3.0 (test reporting)
erikbra
force-pushed
the
chore/meta-grate2
branch
from
35a5eed
to
94ada1f
Compare
This was referenced Apr 18, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dog-fooding: Use grate to version grate tables
Use grate itself to version the grate tables, instead of doing this explicitly in code.
This is good for two reasons:
I introduced a set of "meta" grate tables to handle the versioning of the Grate tables themselves.
So, in addition to (default names):
we add these tables, to version the tables above:
for versioning these tables themselves, we put the versioning in the same tables
(using delayed writing to the tables for bootstrapping)