Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 432: Allow for non-ASCII characters in scripts #501

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Apr 15, 2024

Bug 432: Allow for non-ASCII characters in scripts

This had been working for some databases, but not all.

  • Added failing tests
  • Fixed character set for MariaDb
  • Fixed SQL server, fixed ScriptRunErrors
  • Removed a lot of unused propertied in ISyntax
  • Fixed error ScriptRunErrorsTable -> ScripRunErrors in unit tests
  • Turned of parallelization of test runs in Sqlite tests - had some spurious issues there.
    And, it's not a valid use case to run multiple migrations at once against new databases (I think)
  • Cleaned up the Test setup/teardown for Sqlite

@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:22 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
@erikbra erikbra temporarily deployed to integration-tests April 15, 2024 22:32 — with GitHub Actions Inactive
This had been working for some databases, but not all.

* Added failing tests
* Fixed character set for MariaDb
* Fixed SQL server, fixed ScriptRunErrors
* Removed a lot of unused propertied in ISyntax
* Fixed error ScriptRunErrorsTable -> ScripRunErrors in unit tests
* Turned of parallelization of test runs in Sqlite tests - had some spurious issues there.
  And, it's not a valid use case to run multiple migrations at once against new databases (I thinkg)
* Cleaned up the Test setup/teardown for Sqlite
@erikbra erikbra marked this pull request as ready for review April 18, 2024 16:48
@erikbra erikbra self-assigned this Apr 18, 2024
@erikbra erikbra added the bug Something isn't working label Apr 18, 2024
@erikbra erikbra added this to the 1.7.0 milestone Apr 18, 2024
@erikbra erikbra merged commit ef86983 into main Apr 18, 2024
19 checks passed
@erikbra erikbra deleted the bugs/432-emojis-in-script branch April 18, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant