Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added simple docker example, published to Docker Hub #82

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Added simple docker example, published to Docker Hub #82

merged 1 commit into from
Oct 11, 2021

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Oct 11, 2021

  • Minimal Dockerfile
  • Build and publish container image to Docker Hub on release builds

@erikbra
Copy link
Owner Author

erikbra commented Oct 11, 2021

Probably solves #71 . Paves the ground for #62, possibly #41

@erikbra erikbra requested a review from wokket October 11, 2021 19:28
@erikbra erikbra self-assigned this Oct 11, 2021
@erikbra erikbra added the build-pipeline Build pipeline, publishing, releases, etc label Oct 11, 2021
@erikbra erikbra added this to the 0.9.5 milestone Oct 11, 2021
@erikbra erikbra linked an issue Oct 11, 2021 that may be closed by this pull request
Publish grate docker image to Docker Hub #71
Closed
@erikbra
Copy link
Owner Author

erikbra commented Oct 11, 2021

Would you mind having a look at this one, @wokket ? Does it do what we want wrt a simple image on docker hub?

@erikbra erikbra mentioned this pull request Oct 11, 2021
Closed
@erikbra erikbra force-pushed the features/simple-container-example branch from f8a8f84 to 2c3133b Compare October 11, 2021 19:44
@erikbra erikbra removed the request for review from wokket October 11, 2021 19:46
@erikbra
Copy link
Owner Author

erikbra commented Oct 11, 2021

I think I'll just go ahead and merge this, to get the image to Docker Hub, so we can work on the rest of the issues.

@erikbra erikbra merged commit 9c9102c into main Oct 11, 2021
@erikbra erikbra deleted the features/simple-container-example branch October 11, 2021 19:52
@wokket wokket mentioned this pull request Oct 11, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikbra erikbra

Labels
build-pipeline Build pipeline, publishing, releases, etc
Projects
None yet
Milestone
0.9.5
Development

Successfully merging this pull request may close these issues.

Publish grate docker image to Docker Hub
1 participant
@erikbra