Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: 'select *' and 'group by' can't be used in same time #54

Closed
wants to merge 1 commit into from
Closed

bug: 'select *' and 'group by' can't be used in same time #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sql/plan/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ impl<'a, C: Catalog> Planner<'a, C> {

// Build SELECT clause.
let mut hidden = 0;
if select.is_empty() && ! group_by.is_empty() {
return Err(Error::Value("Wrong use of 'select *' and 'group_by' ".into()));
}
if !select.is_empty() {
// Inject hidden SELECT columns for fields and aggregates used in ORDER BY and
// HAVING expressions but not present in existing SELECT output. These will be
Expand Down