-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ACME support #16
Open
erikh
wants to merge
33
commits into
main
Choose a base branch
from
acme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
- moved acmekit tests to integration tests - made integration tests boot docker in docker - tested that pebble never consults /etc/hosts - I hate computers Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…eded to start a DNS server. Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…ly blown out in configuration Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…onfiguration Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…can finish watching Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…ng routine into solvers Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…r (yet) - solvers still need to be fully implemented - handling teardown+caching needs to be thought through some more Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…uccessful challenge for followers Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…g 'me' Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…locking Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…ment of structures through functions Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
…l work Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Signed-off-by: Erik Hollensbe <git@hollensbe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress; I'm just filing this pull request to get it out in the open that this work is being done, and that we're close to a result.
This implements ACME according to spec, using https://github.com/mholt/acmez as an underlying base. There are some unique challenges that are mostly solved, but not completely yet:
Some of these things are already solved in this branch, and others have yet to be finished. Additionally, the notion of truly graceful restarts (border already cleanly restarts itself, but does not carry outstanding TCP sockets when it does, instead choosing to close them for now) is not covered, but needs to be addressed at a near later point. Configuration distribution is a solved issue, but pumping them into the configuration and re-distributing the updated configuration needs to be done, which is solved in this branch. Finally, reconfiguring the service is also done in this branch, so that it can respond to ACME challenges without allowing unprotected or poorly protected traffic through the underlying service.