Test domains #1
Merged
Test domains #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropped `eqpy.math.fmod`, because it may vary according to platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we remap the API between different project, I want to directly compare output of equivalent functions to verify that the mappings are correct. This branch is a first stab effort to do this. It is a bit rough around the edges (such as possible dependence on floating point approximation error affecting results) and the code isn't particularly pretty, but it is much better than having nothing. Hopefully the tests aren't hyper-sensitive resulting in sporadic failures.
By doing this, I learned that
math.fmodis very finicky, may not be consistent across platforms, and probably isn't the function that the user expects (which would be the mod, or %, function), so it has been removed.This will also allow for much higher confidence if other API mappings are developed.