Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dev option to approporiate location #11

Merged

Conversation

GedasGa
Copy link

@GedasGa GedasGa commented Mar 11, 2019

Platforms affected

electron

Motivation and Context

devTools option can be set inside webPreferences. Therefore, we can deleteisRelease option and set devTools option inside webPreferences instead.

Description

  • Move dev option to the appropriate location.
  • Update tests.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #11 into support-user-defined-electron-settings will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           support-user-defined-electron-settings    #11   +/-   ##
=====================================================================
  Coverage                                     100%   100%           
=====================================================================
  Files                                          14     14           
  Lines                                         568    568           
=====================================================================
  Hits                                          568    568
Impacted Files Coverage Δ
bin/templates/cordova/lib/SettingJsonParser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0e0c9...432edad. Read the comment docs.

@erisu erisu merged commit c53b165 into erisu:support-user-defined-electron-settings Mar 11, 2019
erisu added a commit that referenced this pull request Mar 12, 2019
* Support User Defined Electron Settings
* Move dev option to the appropriate location (#11)
* Updated Docs
@GedasGa GedasGa deleted the move-dev-flag branch June 17, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants