Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate PreCommand Event Listeners #33

Closed
Skillz4Killz opened this issue Oct 24, 2019 · 1 comment
Closed

Duplicate PreCommand Event Listeners #33

Skillz4Killz opened this issue Oct 24, 2019 · 1 comment
Labels
bug something happens that shouldn't changes: api modifies behavior of the public API

Comments

@Skillz4Killz
Copy link
Contributor

Skillz4Killz commented Oct 24, 2019 •
edited
Loading

image

The bottom should probably be changed to command but i think the whole thing should be named postCommand as it is consistent with preCommand and invalidCommand
Skillz4Killz added a commit to Skillz4Killz/yuuko that referenced this issue Oct 25, 2019
@Skillz4Killz
postcommand emit fix. Closes eritbh#33
21d076a
@Skillz4Killz Skillz4Killz mentioned this issue Oct 26, 2019
Merged
@eritbh
Copy link
Owner

eritbh commented Oct 26, 2019

Fixed in #34

@eritbh eritbh closed this as completed Oct 26, 2019
@eritbh eritbh added bug something happens that shouldn't changes: api modifies behavior of the public API labels Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something happens that shouldn't changes: api modifies behavior of the public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eritbh @Skillz4Killz