Command reqs #12
Merged
Command reqs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: documentation, making the interface for creating commands more logical
eritbh
added
enhancement
Can be async or sync, it's a good time
|
Implementing this the way I am because determining whether or not you can run the command should be different than actually running the command. Specifically, this is useful for custom help commands like the one the live bot uses - it doesn't show you commands that you can't use when you request a list of commands. Gonna call this good enough in its current state for 0.6.0, further patch versions can implement other options like passing in a map of permissions or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1, fixes #4
todo: