Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement case-sensitive command option #43

Merged
merged 5 commits into from Dec 22, 2019
Merged

Implement case-sensitive command option #43

merged 5 commits into from Dec 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2019

No description provided.

src/Client.ts Outdated Show resolved Hide resolved
src/Client.ts Outdated Show resolved Hide resolved
src/Client.ts Outdated Show resolved Hide resolved
Ayyan Lewis and others added 2 commits December 21, 2019 08:37
Co-Authored-By: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
@eritbh
Copy link
Owner

eritbh commented Dec 22, 2019

This is a good start, thanks for the contribution! It's missing a couple things that I'll address in further commits:

  • I'd prefer the name of the property to be caseSensitiveCommands (plural).
  • Command names should be converted to lower case when they're added to the bot, to avoid accidentally creating unusable commands through including capital letters in command names. This actually adds way more complexity than I realized, so it's good as it is. I'll add some documentation saying that command names in code must be all lowercase when this flag is false.

@eritbh eritbh merged commit ad3b4ff into eritbh:dev Dec 22, 2019
@eritbh eritbh mentioned this pull request Dec 22, 2019
@ghost ghost deleted the patch-1 branch December 22, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants