Make the high water mark shaper better #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the shaper is in overload and the final message comes in, but no further messages arrive for some time, until another message came in, the drop count would not be printed. Now we set a timer to ensure it prints the drop count after the current second expires. * Allow the shaper to take a filter function that allows events that would not normally be printed anyway to not be counted against the HWM. This means that if you're suppressing supervisor startup messages you won't see drop events counted for messages you'd never see printed.
jadeallenx
reviewed
May 28, 2017
src/error_logger_lager_h.erl
Outdated
| fun(_) -> false end; | ||
| {true, true} -> | ||
| fun({info_report, _GL, {_Pid, std_info, D}}) when is_list(D) -> | ||
| lists:member({exited, stopped}, D); |
There was a problem hiding this comment.
I would really like to see this anonymous fun in its own named function - I think it will make the code clearer and any stacktraces more obvious.
src/error_logger_lager_h.erl
Outdated
| false | ||
| end; | ||
| {false, true} -> | ||
| fun({info_report, _GL, {_Pid, std_info, D}}) when is_list(D) -> |
There was a problem hiding this comment.
Same comment as above. Would you please make this its own named function?
src/error_logger_lager_h.erl
Outdated
| false | ||
| end; | ||
| {true, false} -> | ||
| fun({info_report, _GL, {_P, progress, D}}) -> |
|
Reworked as requested. |
|
👍 Thanks! I think this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
further messages arrive for some time, until another message came in,
the drop count would not be printed. Now we set a timer to ensure it
prints the drop count after the current second expires.
would not normally be printed anyway to not be counted against the
HWM. This means that if you're suppressing supervisor startup messages
you won't see drop events counted for messages you'd never see
printed.