Ingela/ssl gen statem/otp 13464 #1037
Conversation
Also reduce timing issues in tests
DTLS is not in working mode yet, but the gen_statem rewrite should make completion easier.
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
| next_state(StateName, connection, Record, State#state{premaster_secret = undefined, | ||
| public_key_info = undefined, | ||
| tls_handshake_history = ssl_handshake:init_handshake_history()}). | ||
|
|
There was a problem hiding this comment.
It seems that the code to clear the premaster_secret, public_key_info and tls_handshake_history was completely removed.
Is that intended? I guess the new place to do that would be in ssl_connection:prepare_connection ?
Would something like that work: RoadRunnr@40cdec7
|
Good catch it was not intentional I think we should put it in ssl_connection:prepare_connection as you suggested. I merged a later version of this (some dialyzer issues where fixed) branch today as it was deemed stable enough and so that we can continue the work with other PR. |
Please, make it a callback into the {tls,dtls}_connection module. For DTLS there are some additional things to reset. |
The ssl application has been rewritten to use the new behaviour gen_statem. This makes the semantics clearer and avoids some timing issues in the old code. I also think this will make it easier to
complete the DTLS implementation.