erl_types: Fix map type parsing bug (ERL-177) #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t_map/3 previously required callers to perform this normalisation, but as t_from_form/5 would sometimes fail to do so, this requirement is relaxed. Bug (ERL-177) reported and shrunk by Luke Imhoff.
margnus1
changed the title
|
Linking handle into this issue, @KronicDeth = Luke Imhoff |
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
Thanks for the PR @margnus1. How do PRs merged to a |
|
@KronicDeth Looking at the top commit in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t_map/3previously required callers to perform normalisation ofX:=none()pairs, but ast_from_form/5would sometimes fail to do so,this requirement is relaxed.
This caused a dialyzer crash when using remote types as values of
mandatory pairs with singleton keys.
Bug (ERL-177) reported and shrunk by Luke Imhoff.
This PR was previously #1114, but was rebased from maint to maint-19.