Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file erlang-edoc.el to support EDoc in erlang-mode #1157

Closed
wants to merge 1 commit into from
Closed

New file erlang-edoc.el to support EDoc in erlang-mode #1157

wants to merge 1 commit into from

Conversation

leoliu
Copy link
Contributor

@leoliu leoliu commented Sep 3, 2016

  • EDoc markup font-locking and tag completion
  • EDoc comment indentation

@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@dgud
Copy link
Contributor

dgud commented Oct 5, 2016

The file is missing in Makefile and thus installed systems will not have the mode and fail at startup?

If I don't enable the edoc-mode, Messages is cluttered with

let: Symbol's function definition is void: run-hook [21 times]
let: Symbol's function definition is void: run-hook

Hmm I get the warning even after I add enable edoc-mode. emacs-version 24.3.1

@leoliu leoliu closed this Oct 5, 2016
- EDoc markup font-locking and tag completion
- EDoc comment indentation
@leoliu
Copy link
Contributor Author

leoliu commented Oct 5, 2016

The warnings were due to an embarrassing typo. Fixed and rebased.

@leoliu leoliu reopened this Oct 5, 2016
@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@dgud
Copy link
Contributor

dgud commented Oct 6, 2016

Can you rebase the branch to maint. New feature but in dev tool so it is ok to be included in next maint release.

@dgud
Copy link
Contributor

dgud commented Oct 6, 2016

replaced by #1195

@dgud dgud closed this Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants