'can not' should mostly be 'cannot' #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaimoNiskanen
added
the
testing
After this whitespace modification there should be no "can not"s separated by a newline in the entire OTP repository, so to find them all a simple git grep will do just fine.
I did not find any legitimate use of "can not", however skipped changing e.g RFCs archived in the source tree.
RaimoNiskanen
force-pushed
the
raimo/can_not-should-mostly-be-cannot
branch
from
a94c2b6
to
37c11cd
Compare
|
I just removed the changes from |
RaimoNiskanen
added
testing
RaimoNiskanen
removed
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the erlang-questions discussion about 'cannot' /= 'can not' I grepped through the OTP repository and found 204 uses of 'can not' that was not justified.
Before this change there were 1789 uses of 'cannot' and 218 of 'can not'. 14 of the latter still remains, primarily in archived standards documents in the source tree, even though all of them also ought to be changed if they had been ours to change.
To consider is when this kind of broadside to the repository would be least uncomfortable to merge since it touches 120 files in 29 applications...