Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close log files properly in case of inode change #2331

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Close log files properly in case of inode change #2331

merged 1 commit into from
Aug 20, 2019

Conversation

kpy3
Copy link
Contributor

@kpy3 kpy3 commented Jul 23, 2019

Fix file descriptor leak in logger when logrotate used for log management. This bug also exists in maint-22 and master branches.

@kpy3 kpy3 changed the title Close log files in case of inode change properly Close log files properly in case of inode change Aug 5, 2019
@kpy3
Copy link
Contributor Author

kpy3 commented Aug 5, 2019

Hello,

we experiencing serious problems using new logger with logrotate, is there any chances to see this fix in nearest patch set?

@garazdawi
Copy link
Contributor

Hello. Things are moving a bit slow here because of summer vacations. We'll get to this once people start coming back.

@garazdawi garazdawi added fix testing currently being tested, tag is used by OTP internal CI labels Aug 19, 2019
@garazdawi garazdawi changed the base branch from maint-21 to maint August 19, 2019 14:54
@garazdawi garazdawi self-assigned this Aug 20, 2019
@garazdawi garazdawi merged commit d63712d into erlang:maint Aug 20, 2019
@garazdawi
Copy link
Contributor

garazdawi commented Aug 20, 2019

Thanks for your contribution. This fix will be included in the next OTP-21 patch.

@kpy3 kpy3 deleted the fix-fd-leak-in-logger branch August 20, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants