Do not consider map constructors as data in cerl:is_data/1 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimisation passes and cerl_clauses can't handle yet map expressions as data constructors. Reported-by: Ulf Norell
|
Patch has passed first testings and has been assigned to be reviewed |
|
Bug is more general than that and can be triggered by binary expressions too: -module(bug).
f() ->
case <<>> of
<<>> -> ok;
not_map -> error
end.Closing this until I find a better fix. |
|
How did you intend to fix the bug? What I would do is to change case_opt_lit/3 to do two passes. The first would discard any clauses that cannot possibly match. The second pass would rewrite the clauses to eliminate the pattern and update the bindings just as is done now. That would ensure that warnings are generated consistently generated for all clauses that will not match. What is your plan? |
|
That's more or less what I plan to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimisation passes and cerl_clauses can't handle yet map expressions as data constructors.
@UlfNorell