Add is_map_key/2 as a guard BIF to the reference documentation #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, but it's not really a type test bif, so I think it's better to put it in the table of Other BIFs allowed in guards. |
|
Yes, you have a point. Should I move it? It would then be the only |
|
I think move it, but let's leave it to the maintaimers to decide. |
I also think it should be moved. |
tomas-abrahamsson
force-pushed
the
ref-doc-guards-is_map_key
branch
from
aca5aca
to
ea480c9
Compare
|
I moved it to the other table and force-pushed it. |
|
Thanks for your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
is_map_key/2is allowed in guard tests, but the reference documentation currently does not list it, neither the Maps in Guards section, nor the Guard Expressions section. This PR adds it to the reference documentation. I added it to the table of type test BIFs since this is where the rest of theis_...functions are listed.