Fix share-preserve-copy of shared magic ref #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverker
force-pushed
the
sverker/erts/persistent_put_shared_magic_ref
branch
from
03ef571
to
cd6012f
Compare
sverker
force-pushed
the
sverker/erts/persistent_put_shared_magic_ref
branch
from
ca20e4c
to
9c5d883
Compare
If the same magic reference was referred more than once
the reference counter was not increased, leading to later
premature deallocation with all the horrors that could cause.
Example:
Mref = ets:new(x,[]),
persistent_term:put(key, {Mref, Mref}).
into 'sverker/22/copy-shared-magic-ref/OTP-17700'
into 'sverker/23/copy-shared-magic-ref/OTP-17700'
into 'sverker/24/copy-shared-magic-ref/OTP-17700'
with CopyLiterals boolean argument.
to test the sharing preserve copy for combinations of different term types and degrees of sharing.
sverker
force-pushed
the
sverker/erts/persistent_put_shared_magic_ref
branch
from
9c5d883
to
610da14
Compare
garazdawi
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5271
Example:
Would also cause same problem for normal messages passing when built with config
--enable-sharing-preserving.