Ingela/ssl/interop pss tls 1.2/gh 5255/otp 17688 #5277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes erlang#5255 Due to test case allowing fallback algorithms PSS algorithms where not properly selected all the way in TLS-1.2 and some algorithm handling code was missing.
IngelaAndin
added
team:PS
KennethL
reviewed
Oct 11, 2021
Comment on lines
+578
to
+580
| is_supported_sign(rsa_pkcs1_sha512 = SignAlgo, HashSigns) -> %% TLS-1.3 leagcy | ||
| lists:member(SignAlgo, HashSigns) orelse | ||
| lists:member(rsa_pss_rsae_sha384, HashSigns); |
There was a problem hiding this comment.
I think it should be lists:member(rsa_pss_rsae_sha512, HashSigns); here, not rsa_pss_rsae_sha384,
There was a problem hiding this comment.
Good catch I will make a correction branch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl: Fix TLS-1.2 RSASSA-PSS negotiation
Closes #5255