erts: Fix spawn_request trace bug #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the args of spawn_request may end up in a trace we need to allocate them on the heap of the spawning process. We cannot use a temporary heap for this as allocates on normal heap and this will lead to stray pointers on the heap during gc. Stray pointers are not always a problem as any dead data is ignored, but if the pointers and up in a heap fragments they are not ignored...
garazdawi
added
team:VM
rickard-green
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the args of spawn_request may end up in a trace we need to allocate them on the heap of the spawning process.
We cannot use a temporary heap for this as allocates on normal heap and this will lead to stray pointers on the heap during gc. Stray pointers are not always a problem as any dead data is ignored, but if the pointers end up in a heap fragment they are not ignored... so we need to do a proper allocation of the terms.
This bug has existed since OTP-23.0.