beam_disasm: Fix bs_create_bin/6 resolution #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bs_create_bin/6` instruction was previously not fully translated by `beam_disasm`. This change resolves some of the args in the instruction (unwrapping `u` tags) and resolves the operation list to satisfy the checks in `beam_validator:verify_create_bin_list/2`.
CT Test Results 2 files 285 suites 11m 20s ⏱️ Results for commit 2127f85. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for your pull request. |
This was referenced Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bs_create_bin/6instruction was previously not fully translated bybeam_disasm. This change resolves some of the args in the instruction (unwrappingutags) and resolves the operation list to satisfy the checks inbeam_validator:verify_create_bin_list/2.