-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not emit "unexpected" message on shutdown #6810
Do not emit "unexpected" message on shutdown #6810
Conversation
During shutdown, net_kernel process that is linked to an acceptor, gracefully terminates, triggering `{EXIT, net_kernel, shutdown}` message sent to the acceptor. However acceptor does not expect it, and instead of a graceful shutdown logs a confusing warning.
CT Test Results 2 files 64 suites 44m 12s ⏱️ Results for commit df0ef03. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
See the discussion: https://erlangforums.com/t/tls-distribution-unexpected-message-exit-0-178-0-shutdown and original error rabbitmq/rabbitmq-server#7182 Note: this does not fix another issue with the supervision tree of the TLS dist. That second problem manifests like this:
This appears to be caused by Currently |
Regarding df0ef03; I think it is spot on. It will collide with changes I have in 'master', but that is what it is. Regarding the SSL distribution supervision tree vs.
We will see |
Thank you for your pull request! We will have to take a closer look later about what to do about the child in the SSL distribution supervision tree that is being killed during node shutdown... |
During shutdown, net_kernel process that is linked to an acceptor, gracefully terminates, triggering
{EXIT, net_kernel, shutdown}
message sent to the acceptor.However acceptor does not expect it, and instead of a graceful shutdown logs a confusing warning.