Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lists:enumerate/3 #6943

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

Maria-12648430
Copy link
Contributor

The ability to specify a step value seems to me a logical extension to lists:enumerate/2.
I also condensed the docs a bit by combining all three variants of this function into one paragraph.

(Note to self: don't forget to ask for a token for the since tag 😅)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

CT Test Results

       2 files       88 suites   39m 55s ⏱️
1 876 tests 1 828 ✔️ 48 💤 0
2 168 runs  2 118 ✔️ 50 💤 0

Results for commit 5445603.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@bjorng bjorng self-assigned this Mar 1, 2023
@bjorng bjorng added team:VM Assigned to OTP team VM feature labels Mar 1, 2023
Copy link
Contributor

@bjorng bjorng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The ticket id for the since tag is OTP-18495. Please amend your commit and force-push.

@Maria-12648430
Copy link
Contributor Author

Done :)

@bjorng
Copy link
Contributor

bjorng commented Mar 1, 2023

Thanks! Added to our daily builds.

@bjorng bjorng added the testing currently being tested, tag is used by OTP internal CI label Mar 1, 2023
@bjorng bjorng merged commit 91d2bbc into erlang:master Mar 3, 2023
@bjorng
Copy link
Contributor

bjorng commented Mar 3, 2023

Thanks for your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants