Optimize maps:merge/2 of small maps #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 133 suites 52m 46s ⏱️ Results for commit 8a15f4d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
sverker
force-pushed
the
sverker/maps-merge-opt
branch
3 times, most recently
from
fc952ec
to
27cf8d7
Compare
If 2nd map has all keys return it as-is. If 1st map has all keys reuse its key tuple.
If both maps have all the keys and 1st map have a literal key tuple but 2nd map does not, then we mutate 2nd map with literal key tuple before returning it.
sverker
force-pushed
the
sverker/maps-merge-opt
branch
from
8a15f4d
to
93d1dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save heap space when any of the maps have all the keys.
If one of the maps have all the keys we reuse its key tuple.If both maps have all the keys we prefer a literal key tuple.ok, here is the new deal:
maps:merge(A,B) % map B has priority and will supersede values in map A