Add missing message send operator ! to erl_parse:binary_op/0 type #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message send operator ! is listed in terminals of the grammar and an expression node for it is built using ?mkop2() macro, but it's not listed as a valid operator in the definition of binary_op/0 type. This commit adds it there.
erszcz
force-pushed
the
add-bang-to-erl-parse-binary-op-type
branch
from
94b0c76
to
f38f301
Compare
CT Test Results 2 files 85 suites 34m 4s ⏱️ For more details on these failures, see this check. Results for commit f38f301. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for your pull request. It is too late to include in Erlang/OTP 25.3, so it will be included in a patch release. |
|
I am closing this PR because I've included its correction in #7013. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message send operator
!is listed in terminals of the grammar and an expression node for it is built using?mkop2()macro, but it's not listed as a valid operator in the definition of thebinary_op/0type. This commit adds it there.This PR is the same as #6954 but it targets
maintinstead ofmaster.